RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

[Opensource [Anthony Olech]]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
> Sent: 17 September 2012 12:33
> To: Opensource [Anthony Olech]
> Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David
> Dajun Chen
> Subject: Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver
> On Mon, Sep 17, 2012 at 11:23:54AM +0000, Opensource [Anthony Olech]
> wrote:
> > Can you suggest a future proofed way of using the new regulator API
> > that would solve my problem?
> As I said you should set the voltage as part of the set voltage operation.

So I will have to write my own set_voltage_sel() callback instead of using
the default regulator_set_voltage_sel_regmap() ??

Well, I did try hard to use your defaults, but I suppose there is nothing to
stop me calling regulator_set_voltage_sel_regmap() explicitly as the first
part of my set_voltage_sel() callback before setting the ramp_enable bit.
Then my implemenation of the set_voltage_time_sel() callback needs to
just simply return the ramp time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/