Re: [PATCH repost] virtio: don't crash when device is buggy

From: Rusty Russell
Date: Mon Sep 17 2012 - 07:36:14 EST


"Michael S. Tsirkin" <mst@xxxxxxxxxx> writes:

> Because of a sanity check in virtio_dev_remove, a buggy device can crash
> kernel. And in case of rproc it's userspace so it's not a good idea.
> We are unloading a driver so how bad can it be?
> Be less aggressive in handling this error: if it's a driver bug,
> warning once should be enough.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
>
> --
>
> 3.6 material?

I have already applied, this, but it's not for stable, since it's a
"theoretical bugfix". That check has been in there forever and noone
AFAIK has actually struck it.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/