Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

[Mark Brown]

On Mon, Sep 17, 2012 at 10:29:43AM +0000, Opensource [Anthony Olech] wrote:

> > Why is this function writing to the hardware, especially writing the same value
> > every time?

> the ramp_register is DA9058_SUPPLY_REG and it is marked as volitile.
> Writing to the ramp enable bit starts the voltage change. When the PMIC has
> finished making the change it resets the bit. Thus to make another voltage
> change the bit needs to be set again.

This function is retrieving the amount of time it would take to set the
voltage.  Why would it be starting a voltage ramp?  The fact that it's
not setting the new voltage in the hardware ought to be a warning sign
here...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/