RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

[Xie Shaohui-B21989]

> -----Original Message-----
> From: Shaun Ruffell [mailto:sruffell@xxxxxxxxxx]
> Sent: Saturday, September 15, 2012 2:22 AM
> To: Xie Shaohui-B21989
> Cc: linux-edac@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> akpm@xxxxxxxxxxxxxxxxxxxx; avorontsov@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; grant.likely@xxxxxxxxxxxx
> Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe
> 
> On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote:
> > Error handle in case of DDR ECC off is wrong, sysfs entries have not
> > been created, so edac_mc_free which frees a mci instance should not be
> called.
> > Also, free mci's memory in this case.
> 
> Jus FYI: I ran into the same error in edac_mc_free() which I resolved in
> a slightly different way in some patches I sent previously. [1]
> 
> [1] https://lkml.org/lkml/2012/9/14/475
[S.H] Thanks! I did not aware of this patch when one of my colleague asked me to have a look at the issue,
It could save me some time if I saw this patch earlier. :(

BTW: seems you are using a different kernel tree with mine.

Best Regards, 
Shaohui Xie

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/