Re: [PATCH 24/24] ARM: msm: Allow 8960 and 8660 to compile together

[Olof Johansson]

Hi,

On Wed, Sep 12, 2012 at 9:59 AM, David Brown <davidb@xxxxxxxxxxxxxx> wrote:
> From: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>
> Modify the Kconfig to allow the MSM 8660 and MSM 8960 targets to
> compile together in the same build. As long as one of these two
> targets is selected the choice menu used to select which SoC to
> support will be hidden. Deselecting both of these targets will
> reintroduce the choice menu, and allow users to select targets
> that must be compiled in isolation.
>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> Signed-off-by: David Brown <davidb@xxxxxxxxxxxxxx>
> ---
>  arch/arm/mach-msm/Kconfig | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig
> index b2740c8..7902de15 100644
> --- a/arch/arm/mach-msm/Kconfig
> +++ b/arch/arm/mach-msm/Kconfig
> @@ -1,8 +1,12 @@
>  if ARCH_MSM
>
> +comment "Qualcomm MSM SoC Type"
> +       depends on (ARCH_MSM8X60 || ARCH_MSM8960)

This OK for now but will stop scaling pretty quickly.

When you introduce the next SoC to this, please add a new silent
option instead, that the multi-soc-capable configs select and switch
the depends over to that option.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/