Re: [PATCH 2/6] drivers/mfd: drop frees of devm allocated data

From: Samuel Ortiz
Date: Sun Sep 16 2012 - 19:24:44 EST


Hi Julia,

On Mon, Aug 13, 2012 at 09:36:06PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> devm_kfree should not have to be explicitly used.
> devm_regmap_init_i2c also does not require an explicit free.
>
> The semantic patch that fixes the first problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,d;
> @@
>
> x = devm_kzalloc(...)
> ...
> ?-devm_kfree(d,x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> v2: Removed over-eager optimization of some error-handling code.
>
> drivers/mfd/88pm800.c | 5 +----
> drivers/mfd/88pm80x.c | 19 +++----------------
> 2 files changed, 4 insertions(+), 20 deletions(-)
This one does not apply to my for-next branch, would you please mind rebasing
it against that branch ?

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/