Re: [PATCH 3/5] uprobes: Fix UPROBE_SKIP_SSTEP checks inhandle_swbp()
From: Ananth N Mavinakayanahalli
Date: Sat Sep 15 2012 - 03:41:01 EST
On Fri, Sep 14, 2012 at 07:15:57PM +0200, Oleg Nesterov wrote:
> If handle_swbp()->add_utask() fails but UPROBE_SKIP_SSTEP is set,
> cleanup_ret: path do not restart the insn, this is wrong. Remove
> this check and add the additional label for can_skip_sstep() = T
> Note also that UPROBE_SKIP_SSTEP can be false positive, we simply
> can not trust it unless arch_uprobe_skip_sstep() was already called.
> Also, move another UPROBE_SKIP_SSTEP check before can_skip_sstep()
> into this helper, this looks more clean and understandable.
> Note: probably we should rename "skip" to "emulate" and I think
> that "clear UPROBE_SKIP_SSTEP" should be moved to arch_can_skip.
Agree. emulate is more accurate in this situation since, especially on
powerpc, we do emulate most instructions.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/