Re: [PATCH] cgroup: net_cls: Include missing header with sock_update_classid()definition

[Daniel Wagner]

Hi Sedat,

On 14.09.2012 16:43, Sedat Dilek wrote:
> On Fri, Sep 14, 2012 at 4:33 PM, Daniel Wagner <wagi@xxxxxxxxx> wrote:
> > From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> >
> > commit 1f66c0a8833c3974ab6b35edcf4f8585b2f94592
> > Author: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> > Date:   Wed Sep 12 16:12:01 2012 +0200
> >
> >      cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h
> >
> > Claimed that there was only net/socket.c depending on
> > sock_update_class(). That is not true drivers/net/tun.c needs to
> > include the cls_cgroup.h header too.
> >
> > Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> > Cc: Gao feng <gaofeng@xxxxxxxxxxxxxx>
> > Cc: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>
> > Cc: Joe Perches <joe@xxxxxxxxxxx>
> > Cc: John Fastabend <john.r.fastabend@xxxxxxxxx>
> > Cc: Li Zefan <lizefan@xxxxxxxxxx>
> > Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
> > Cc: Rick Jones <rick.jones2@xxxxxx>
> > Cc: Stanislav Kinsbursky <skinsbursky@xxxxxxxxxxxxx>
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Cc: cgroups@xxxxxxxxxxxxxxx
> > ---
> >
> > This version is on top of the latest cgroup for-3.7 branch.
>
> Thanks for the quick fix.

No problem. I am still ashamed not finding it myself.

> Please honour Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>.

Sure, will do next time.

> If this is the fix for the breakage in today's Linux-Next
> (next-20120914), please add a "-next" to the subject next time.

Correct, this one is for linux-next but I got the impression that cgroup 
for-3.7 branch was ignored because of this. Therefore I have send two 
versions. Hmm, I'll need to check the results of todays next tree.

thanks,
daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/