Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

From: navin patidar
Date: Fri Sep 14 2012 - 10:29:04 EST


hi,

I have sent this patch again with corrections.
thank for reviewing the patch.

--navin-patidar

On 9/14/12, Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx> wrote:
> On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote:
>> >diff --git a/drivers/staging/usbip/stub_dev.c
>> > b/drivers/staging/usbip/stub_dev.c
>> >index 92ced35..f584af8 100644
>> >--- a/drivers/staging/usbip/stub_dev.c
>> >+++ b/drivers/staging/usbip/stub_dev.c
>> >@@ -233,6 +230,13 @@ static void stub_device_reset(struct usbip_device
>> > *ud)
>> >
>> > dev_dbg(&udev->dev, "device reset");
>> >
>> >+ /*reset tcp socket*/
>>
>> Add spaces after /* and before */, please.
>>
>> >+ ud->tcp_socket = NULL;
>> >+
>> >+ /*reset kernel thread pointers */
>>
>> Here too.
>
> I'm not sure it is required to comment the obvious things.
>
>> WBR, Sergei
>
> Sebastian
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/