Re: [PATCH 10/19] ARM: ux500: Remove redundant #gpio-cell propertiesfrom HREF and Snowball DT

From: Linus Walleij
Date: Fri Sep 14 2012 - 09:58:07 EST

On Fri, Sep 14, 2012 at 11:10 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Mon, Sep 10, 2012 at 04:12:23AM -0700, Linus Walleij wrote:
>> On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> > These properties have no place here as the populated nodes are
>> > not related to GPIO Controllers.
>> >
>> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>> Squash this into the previous patch adding them...
>> I think Arnd already noted.
> Well he noted that I'd duplicated the error from the snowball.dts
> file, then rectified in this patch, which is fair enough. However,
> I don't think the snowball.dts fix should be squashed into an HREF
> enablement patch, and I can't find a suitable patch in the patch-
> set where it would really fit. Should I leave the Snowball fix
> separate and just fixup the HREF .dts file to never duplicate the
> anomaly?

No you're right, this should be separate.

I was confused that it was in the same patch set, I would
suggest just sending this one on it's own as a snowball fix
fair and square, and have ARM SoC push it to the -rcs as a
regression fix, but your choice.
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at