Re: [PATCH] gmux: Fix backlight set function

From: Grant Likely
Date: Fri Sep 14 2012 - 09:07:01 EST


On Thu, Sep 13, 2012 at 9:35 PM, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
> On Thu, 2012-09-13 at 21:02 +0100, Grant Likely wrote:
>> In commit 7e30ed6b, "gmux: Add generic write32 function", the new
>> gmux_write32() function didn't include the io offset when writing
>> registers. This means that backlight update writes never go to the
>> right
>> place. This patch fixes it.
>>
>> Tested on Apple Macbook 8,3
>
> Aha, thanks. I was going to have to get to that in the next few days.
>
> I also noticed that since updating to the latest kernel and the latest
> version of all the patches, I never get Intel graphics output working
> after switching. And even the Radeon doesn't work right, if I switch
> away and back. X just locks up after a few seconds and the graphics
> engine isn't responding.

What patches are you running on top of mainline for the mbp8,3? I'm
using the radeon blos loading patch and I've got the nasty direct io
writes in grub.cfg to disable the radeon before booting into the
kernel so that X picks up the i915 instead. I'm also passing
"i915.lvds_channel_mode=2 i915.modeset=1 i915.lvds_use_ssc=0
i915.i915_enable_rc6=1 vt.handoff=7" on the command line, but I
haven't experimented with it recently to see if that is still
required.

I've not had time to play with switcharoo on this system though. :-(

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/