Re: [PATCH] amd64_edac: Memory size reported double on processorfamily 0Fh

[Josh Hunt]

On 09/12/2012 12:23 PM, Borislav Petkov wrote:
> Ok, I have something preliminary which seems to work fine on my K8 here.
> If you'd like, you can give it a run:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git error-queue
>
> I've changed also debug messages, etc, so pls take a look at those and
> let me know whether they're understandable, make sense, etc, etc.

Boris

Thanks to your help I was able to test your branch, but it still does 
not resolve the problem. Removal of the "factor=1" workaround fixes the 
memory size reporting on boot, but the sysfs values are still incorrect.

[   25.836264] EDAC MC: DCT0 chip selects:
[   25.836266] EDAC amd64: MC: 0:  1024MB 1:  1024MB
[   25.836398] EDAC amd64: MC: 2:  1024MB 3:  1024MB
[   25.836530] EDAC amd64: MC: 4:     0MB 5:     0MB
[   25.836662] EDAC amd64: MC: 6:     0MB 7:     0MB

root@xxxxxxxxxxx:/sys/devices/system/edac/mc/mc0# grep . *
ce_count:0
ce_noinfo_count:0
dbam:0x0000000000000022
dhar:0x00000000ee001201
dram_hole:ee000000 12000000 12000000
max_location:csrow 7 channel 1
mc_name:K8
grep: reset_counters: Permission denied
sdram_scrub_rate:761
seconds_since_reset:276
size_mb:8192
topmem:0x00000000ee000000
topmem2:0x0000000112000000
ue_count:0
ue_noinfo_count:0

root@xxxxxxxxxxx:/sys/devices/system/edac/mc/mc0/csrow1# grep . *
ce_count:0
ch0_ce_count:0
ch0_dimm_label:mc#0csrow#0channel#1
ch1_ce_count:0
ch1_dimm_label:mc#0csrow#4channel#1
dev_type:Unknown
edac_mode:S4ECD4ED
mem_type:Unbuffered-DDR2
size_mb:2048
ue_count:0

To be sure I'm using the correct branch the last git log entry is:
9d67117feece8852570cc8ee25b68c41f8def323

I could be incorrect, but I still think there's a problem with either a) 
ddr2_cs_size() for this cpu, or b) the extra shift left when WIDTH_128 
is true.

Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/