Re: [PATCH] Xen backend support for paged out grant targets.

From: Ian Campbell
Date: Fri Sep 14 2012 - 03:19:00 EST


On Thu, 2012-09-13 at 20:45 +0100, Andres Lagar-Cavilla wrote:
> On Sep 13, 2012, at 2:11 PM, Ian Campbell wrote:
>
> > On Thu, 2012-09-13 at 18:28 +0100, Andres Lagar-Cavilla wrote:
> >>
> >> * Add placeholder in array of grant table error descriptions for
> >> unrelated error code we jump over.
> >
> > Why not just define it, it's listed here:
> > http://xenbits.xen.org/docs/unstable/hypercall/include,public,grant_table.h.html#Enum_grant_status
> Well, a) we'd be defining something no one will be using (for the
> moment)

Even if no one in the kernel is using it, having "placeholder" as an
entry in GNTTABOP_error_msgs is just silly, even things which don't
understand GNTST_address_too_big directly could end up looking it up
here.

> b) I would be signing-off on something unrelated.

Lets take this patch instead then.

8<------------------------------------------------