Re: [PATCH 07/24] Staging: ipack/devices/ipoctal: Store isr masks inipoctal_channel

[Dan Carpenter]

On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> From: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> 
> This way interrupt handling becomes independent of the channel number.
> 
> Signed-off-by: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>
> ---
> @@ -213,7 +206,7 @@ static int ipoctal_irq_handler(void *arg)
>  		}
>  
>  		/* RX data */
> -		if (isr_rx_rdy && (sr & SR_RX_READY)) {
> +		if ((isr && channel->isr_rx_rdy_mask) && (sr & SR_RX_READY)) {
                         ^^
Bitwise AND intended here I think.

>  			value = ioread8(&channel->regs->r.rhr);
>  			flag = TTY_NORMAL;
>  
> @@ -244,7 +237,7 @@ static int ipoctal_irq_handler(void *arg)
>  		}
>  
>  		/* TX of each character */
> -		if (isr_tx_rdy && (sr & SR_TX_READY)) {
> +		if ((isr & channel->isr_tx_rdy_mask) && (sr & SR_TX_READY)) {


regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/