Re: [Xen-devel] [PATCH 09/10] xen/swiotlb: Fix compile warnings whenusing plain integer instead of NULL pointer.

From: Ian Jackson
Date: Thu Sep 13 2012 - 11:53:48 EST


Konrad Rzeszutek Wilk writes ("[Xen-devel] [PATCH 09/10] xen/swiotlb: Fix compile warnings when using plain integer instead of NULL pointer."):
> arch/x86/xen/pci-swiotlb-xen.c:96:1: warning: Using plain integer as NULL pointer
> arch/x86/xen/pci-swiotlb-xen.c:96:1: warning: Using plain integer as NULL pointer

This warning is simply wrong for this code:

> IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
> - 0,
> + NULL,

There is (according to the C language specifications) nothing wrong
with writing 0 for a null pointer.

Nor does CODING_STYLE say that it is forbidden to just write 0.

Ian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/