Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

From: Federico Vaga
Date: Thu Sep 13 2012 - 11:38:42 EST


> typo: steaming -> streaming :-)

fixed

> The header and esp. the source could really do with more
> documentation. It is not at all clear from the code what the
> dma-streaming allocator does and how it differs from other
> allocators.

The other allocators are not documented and to understand them I read
the code. All the memory allocators reflect a kind of DMA interface: SG
for scatter/gather, contig for choerent and (now) streaming for
streaming. So, I'm not sure to understand what do you think is the
correct way to document a memory allocator; I can write one or two lines
of comment to summarize each function. what do you think?

--
Federico Vaga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/