Re: [PATCH v2] pinctrl: pinctrl-single: Add pinctrl-single,bits typeof mux
From: Peter Ujfalusi
Date: Thu Sep 13 2012 - 03:35:37 EST
On 09/13/2012 09:52 AM, Linus Walleij wrote:
> On Wed, Sep 12, 2012 at 10:27 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>> * Peter Ujfalusi <peter.ujfalusi@xxxxxx> [120911 01:54]:
>>> With pinctrl-single,bits it is possible to update just part of the register
>>> within the pinctrl-single,function-mask area.
>>> This is useful when one register configures mmore than one pin's mux.
>>> size /= sizeof(*mux); /* Number of elements in array */
>>> - rows = size / 2; /* Each row is a key value pair */
>>> + rows = size / params; /* Each row is a key value pair */
>> Maybe just remove the comment: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> I don't think it's needed any longer. Other than that,
>> thanks for updating the patch:
>> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> Applied minus the comment, plus Tony's ACK, thanks!
Thank you Linus, I was about to send the v3 with the removed comment.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/