Re: [PATCH 0/3] Minor changes to common hugetlb code for ARM

[Andrea Arcangeli]

Hi everyone,

On Wed, Sep 12, 2012 at 05:27:59PM +0200, Michal Hocko wrote:
> On Tue 11-09-12 17:47:13, Will Deacon wrote:
> > Hello,
> 
> Hi,
> 
> > A few changes are required to common hugetlb code before the ARM support
> > can be merged. I posted the main one previously, which has been picked up
> > by akpm:
> > 
> >   http://marc.info/?l=linux-mm&m=134573987631394&w=2
> > 
> > The remaining three patches (included here) are all fairly minor but do
> > affect other architectures.
> 
> I am quite confused. Why THP changes are required for hugetlb code for
> ARM?

Some functions are just noops on x86 and with no arch other than x86
building the huge_memory.c file, those x86-noop parts that needed
minor interface adjustments couldn't be noticed until now.

Hopefully we got the brainer part right (i.e. the location of the x86
noop callouts), it's clearly untested.

> Besides that I would suggest adding Andrea to the CC (added now the
> whole series can be found here http://lkml.org/lkml/2012/9/11/322) list
> for all THP changes.
> 
> > 
> > All comments welcome,
> > 
> > Will
> > 
> > Catalin Marinas (2):
> >   mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear()
> >   mm: thp: Fix the update_mmu_cache() last argument passing in
> >     mm/huge_memory.c

Both:

Reviewed-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>

> > 
> > Steve Capper (1):
> >   mm: Introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE

This was already introduced by the s390 THP support which I reviewed a
few days ago, and it's already included in -mm, so it can be dropped.

Thanks!
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/