Re: [Drbd-dev] FLUSH/FUA documentation & code discrepancy
From: Joseph Glanville
Date: Wed Sep 12 2012 - 19:53:07 EST
On 13 September 2012 09:20, Tejun Heo <tj@xxxxxxxxxx> wrote:
> On Thu, Sep 13, 2012 at 09:12:25AM +1000, Joseph Glanville wrote:
>> diff --git a/block/blk-core.c b/block/blk-core.c
>> index 4b4dbdf..68b5671 100644
>> --- a/block/blk-core.c
>> +++ b/block/blk-core.c
>> @@ -1809,6 +1809,9 @@ EXPORT_SYMBOL(generic_make_request);
>> * uses that function to do most of the work. Both are fairly rough
>> * interfaces; @bio must be presetup and ready for I/O.
>> + * Ordering of requests is not guaranteed, callers should drain the queue
>> + * and issue a flush before submission of any dependent bios.
> I think using "requests" here is confusing given that struct request
> means something else in the block layer. Also, the caller doesn't
Agreed, my bad.
> have to drain the whole queue but just the ones involved in the
> dependency and flush doesn't really matter here although mentioning
> that flush too doesn't have any ordering guarantee would be nice.
Would you prefer it being added to the top of the file describing the
semantics or the blkdev_issue_flush function itself?
> Also, updating submit_bio() comment too would be nice - something
> simple about lack of ordering and then reference to
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
CTO | Orion Virtualisation Solutions | www.orionvm.com.au
Phone: 1300 56 99 52 | Mobile: 0428 754 846
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/