Re: [PATCH 2/2] ARM: AM33XX: hwmod: Add OMAP_INTC_START offset toall module int nos

From: Tony Lindgren
Date: Wed Sep 12 2012 - 17:52:42 EST


* Vaibhav Hiremath <hvaibhav@xxxxxx> [120912 14:17]:
> With recent migration of omap architectures to SPARSE_IRQ framework,
> it is important to add OMAP_INTC_START to all interrupt numbers
> which will be eventually requested by drivers.
>
> This is required in order to get AM33XX boot functionality.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> Cc: Paul Walmsley <paul@xxxxxxxxx>
> ---
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 168 ++++++++++++++--------------
> 1 files changed, 84 insertions(+), 84 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index 7b7ed08..3c320f4 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c

You should just have on top of this file:

#define OMAP_INTC_START 0

Then Paul can apply this, and while merging with the sparseirq
changes, the above can be removed.

> @@ -72,7 +72,7 @@ static struct omap_hwmod_class am33xx_emif_hwmod_class = {
> };
>
> static struct omap_hwmod_irq_info am33xx_emif_irqs[] = {
> - { .name = "ddrerr0", .irq = 101 },
> + { .name = "ddrerr0", .irq = 101 + OMAP_INTC_START },
> { .irq = -1 }
> };
>

Then these should be fixed up to have trailing commas
as requested by Russell earlier on several occasions.

Regards,

Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/