Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

From: Tejun Heo
Date: Wed Sep 12 2012 - 16:39:16 EST


Hello,

On Wed, Sep 12, 2012 at 12:06:48PM -0400, Cyril Chemparathy wrote:
> static void * __init alloc_bootmem_core(unsigned long size,
> unsigned long align,
> - unsigned long goal,
> - unsigned long limit)
> + phys_addr_t goal,
> + phys_addr_t limit)

So, a function which takes phys_addr_t for goal and limit but returns
void * doesn't make much sense unless the function creates directly
addressable mapping somewhere.

The right thing to do would be converting to nobootmem (ie. memblock)
and use the memblock interface. Have no idea at all whether that
would be a realistic short-term solution for arm.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/