Re: [PATCH v2] pinctrl: pinctrl-single: Add pinctrl-single,bitstype of mux

From: Tony Lindgren
Date: Wed Sep 12 2012 - 16:26:59 EST

* Peter Ujfalusi <peter.ujfalusi@xxxxxx> [120911 01:54]:
> With pinctrl-single,bits it is possible to update just part of the register
> within the pinctrl-single,function-mask area.
> This is useful when one register configures mmore than one pin's mux.

> size /= sizeof(*mux); /* Number of elements in array */
> - rows = size / 2; /* Each row is a key value pair */
> + rows = size / params; /* Each row is a key value pair */

Maybe just remove the comment: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I don't think it's needed any longer. Other than that,
thanks for updating the patch:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at