Re: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removesuseless kfree()

From: Peter Senna Tschudin
Date: Wed Sep 12 2012 - 11:50:50 EST


> Now that you removed this kfree, you could remove this label too. Very
> nice your cleanup :)

>> vpbe_fail_sd_register:
>> kfree(vpbe_dev->encoders);
>> vpbe_fail_v4l2_device:

The problem removing the label is that it will require some more work
naming the labels. See:
if (!vpbe_dev->amp) {
goto vpbe_fail_amp_register;

If I just remove the label vpbe_fail_amp_register, the label names
will not make sense any more as the next label is
vpbe_fail_sd_register. So I will need to change the name to something
different or rename all labels to out1, out2, out3 or err1, err2,
err3, or ....

Any suggestions?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at