Re: [PATCH 2/3] scsi: create an all-zero filter for scanners

From: Paolo Bonzini
Date: Wed Sep 12 2012 - 08:33:03 EST


Il 12/09/2012 14:36, Alan Cox ha scritto:
>> > switch (sdev->type) {
>> > + case TYPE_SCANNER:
>> > + sdev->request_queue->cmd_filter =
>> > + kzalloc(sizeof(struct blk_cmd_filter), GFP_KERNEL);
>> > + /* fallthrough */
> Is that really desireable in the kzalloc failing case ?

Hmm, there is another kmalloc failure in the series that is worse than
this one, actually.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/