Re: [PATCH 1/4] staging: omap-thermal: Correct warnings

From: Dan Carpenter
Date: Wed Sep 12 2012 - 04:11:30 EST

On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
> From: J Keerthy <j-keerthy@xxxxxx>
> Removes checkpatch warnings on omap-bandgap.c.

Which warnings?

> + omap_bandgap_writel(bg_ptr,
> + rval->tshut_threshold,
> + tsr->tshut_threshold);

That's just whacky.

Personally, I've never cared much about long lines, so I'd prefer
to leave these as is until someone can break the functions up and
remove them in a proper way instead of just shifting everything
randomly to the left.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at