Re: [PATCH 2/2] ARM: OMAP2+: Enable pinctrl dummy states

From: Tony Lindgren
Date: Tue Sep 11 2012 - 14:03:03 EST


* Matt Porter <mporter@xxxxxx> [120911 10:46]:
> Enable pinctrl dummy states for all OMAP platforms. This allows
> drivers to be converted to pinctrl while still running on
> platforms that do not provide pinctrl data.
>
> Signed-off-by: Matt Porter <mporter@xxxxxx>
> ---
> arch/arm/mach-omap2/devices.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index c00c689..577cd04 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -17,6 +17,7 @@
> #include <linux/err.h>
> #include <linux/slab.h>
> #include <linux/of.h>
> +#include <linux/pinctrl/machine.h>
> #include <linux/platform_data/omap4-keypad.h>
>
> #include <mach/hardware.h>
> @@ -631,6 +632,9 @@ static inline void omap_init_vout(void) {}
>
> static int __init omap2_init_devices(void)
> {
> + /* Enable dummy states for those platforms without pinctrl support */
> + pinctrl_provide_dummies();
> +
> /*
> * please keep these calls, and their implementations above,
> * in alphabetical order so they're easier to sort through.

Hmm I think this may need to be board specific. And may need to
be board specific and depend on unpopulated device tree?

For board-generic.c we always want to see the warnings. And some boards
insist on doing all the muxing only in the bootloader.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/