Re: [PATCH v2] x86/mce: Honour bios-set CMCI threshold

From: Tony Luck
Date: Tue Sep 11 2012 - 12:04:35 EST

On Mon, Sep 10, 2012 at 10:31 PM, Naveen N. Rao
<naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:
> + if (mce_bios_cmci_threshold)
> + printk_once(KERN_INFO
> + "bios_cmci_threshold: Using bios-set threshold values for CMCI");

Do we really need this message? The user knows whether they gave
the command line option or not (and can check in /proc/cmdline if
they forgot whether they did). If it is needed, then you should add
a "\n" to it.

> + if (mce_bios_cmci_threshold && bios_wrong_thresh) {
> + printk_once(KERN_INFO
> + "bios_cmci_threshold: Some banks do not have valid thresholds set");
> + printk_once(KERN_INFO
> + "bios_cmci_threshold: Make sure your BIOS supports this boot option");

Also need "\n"

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at