Re: [PATCH] mfd: core: Push irqdomain mapping out into devices

From: Samuel Ortiz
Date: Tue Sep 11 2012 - 06:17:21 EST

Hi Mark, Lee,

On Tue, Sep 11, 2012 at 03:16:36PM +0800, Mark Brown wrote:
> Currently the MFD core supports remapping MFD cell interrupts using an
> irqdomain but only if the MFD is being instantiated using device tree
> and only if the device tree bindings use the pattern of registering IPs
> in the device tree with compatible properties. This will be actively
> harmful for drivers which support non-DT platforms and use this pattern
> for their DT bindings as it will mean that the core will silently change
> remapping behaviour and it is also limiting for drivers which don't do
> DT with this particular pattern. There is also a potential fragility if
> there are interrupts not associated with MFD cells and all the cells are
> omitted from the device tree for some reason.
> Instead change the code to take an IRQ domain as an optional argument,
> allowing drivers to take the decision about the parent domain for their
> interrupts. The one current user of this feature is ab8500-core, it has
> the domain lookup pushed out into the driver.
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> This should incorporate a fix Lee Jones created for ab8500, though he
> was only able to describe it verbally and not send a patch so I'd like
> some confirmation from him that it's OK.
I'm applying this one to my for-linus branch and I'd like to send a pull
request to Linus in a few days. Lee, could you please confirm that it's OK
with you ?


Intel Open Source Technology Centre
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at