Re: [PATCH] Staging: comedi: drivers: fl512: changeprintk(KERN_INFO ... for the prefered pr_info(...

[Joe Perches]

On Mon, 2012-09-10 at 20:44 -0700, Greg KH wrote:
> On Mon, Sep 10, 2012 at 08:40:11PM -0700, Joe Perches wrote:
> > On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> > > On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > > > Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the prefered pr_info, pr_warn and pr_error
> > []
> > > > diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> > []
> > > > @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> > []
> > > > -	printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> > > > +	pr_info("comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> > > 
> > > Why can't you use dev_info() here, and in other places?  You should use
> > > the dev_* functions instead of pr_* wherever possible.
> > 
> > Checkpatch instigates these conversions.
> 
> I know.
> 
> > Perhaps something like:
> 
> That looks like a good start, until someone tries to use netdev_* in a
> random non-network driver :)

Hence the "netdev_<level>(netdev, ...) then dev_<level>(dev, ..., etc...

You can only make people read not understand.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/