Re: [PATCH 10/14] tty/serial: Add kgdb_nmi driver

From: Anton Vorontsov
Date: Mon Sep 10 2012 - 13:57:05 EST


On Mon, Sep 10, 2012 at 12:11:05PM +0100, Alan Cox wrote:
> On Sun, 9 Sep 2012 21:14:12 -0700
> Anton Vorontsov <anton.vorontsov@xxxxxxxxxx> wrote:
>
> > This special driver makes it possible to temporary use NMI debugger port
> > as a normal console by issuing 'nmi_console' command (assuming that the
> > port is attached to KGDB).
>
> No ref counting, no tty port, no compliance with the tty behaviour.
> Concept looks fine but it needs porting to reflect a kernel newer than
> about 2.6.18 8)

:-)

I'll look into tty_port helpers, much thanks for the review!

> I would take a quick look at the tty_port helpers and also check v -next
> which makes the tty_port mandatory. That'll pretty much cover your needs
> for locking, semantics and the like.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/