Re: [PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code forVPIF to work

From: Sekhar Nori
Date: Mon Sep 10 2012 - 05:27:45 EST


Hi Prabhakar,

On 9/7/2012 11:04 PM, Prabhakar Lad wrote:
> On Fri, Sep 7, 2012 at 10:48 PM, Sekhar Nori <nsekhar@xxxxxx> wrote:

>>> +static struct vpif_subdev_info da850_vpif_capture_sdev_info[] = {
>>> +#if defined(CONFIG_DA850_UI_SD_VIDEO_PORT)
>>
>> You agreed to get rid of these multiple ifdefs but you have not fixed that.
>>
> I have merged the top one, at later stage when we go ahead and add sensor
> support then we would have require to have define two
> da850_vpif_capture_sdev_info
> so to avoid it I have kept this one.

Lets get to that when we actually add sensor support. It might make
sense then. Right now, there is no reason to have them.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/