Re: [PATCH v5] media: v4l2-ctrls: add control for dpcm predictor

From: Sakari Ailus
Date: Mon Sep 10 2012 - 03:32:39 EST


Hi Prabhakar,

On Mon, Sep 10, 2012 at 11:27:55AM +0530, Prabhakar Lad wrote:
...
> + <row id="v4l2-dpcm-predictor">
> + <entry spanname="descr"> Differential pulse-code modulation (DPCM) compression can
> + be used to compress the samples into fewer bits than they would otherwise require.
> + This is done by calculating the difference between consecutive samples and outputting
> + the difference which in average is much smaller than the values of the samples
> + themselves since there is generally lots of correlation between adjacent pixels. In
> + decompression the original samples are reconstructed. The process isn't lossless as
> + the encoded sample size in bits is less than the original.
> +
> + <para>Formats using DPCM compression include <xref linkend="pixfmt-srggb10dpcm8" />.</para>
> +
> + <para>This control is used to select the predictor used to encode the samples.</para>
> +
> + <para>The main difference between the simple and the advanced predictors is image quality,
> + with advanced predictor supposed to produce better quality images as a result. Simple
> + predictor can be used e.g. for testing purposes. For more information about DPCM see <ulink
> + url="http://en.wikipedia.org/wiki/Differential_pulse-code_modulation";>Wikipedia</ulink>.</para>

Could you fit the above text (description of the control) at 80 characters
per line? With that change,

Acked-by: Sakari Ailus <sakari.ailus@xxxxxx>

Kind regards,

--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/