Re: [PATCH 2/2] backlight: add new lm3639 backlight driver

From: gshark
Date: Mon Sep 10 2012 - 03:13:14 EST

LM3639 has not only pins for backlihgt but also pins for LEDs. So it uses functions in led_class and led_core file.
When I see your config file, "randconig", you set CONFIG_NEW_LEDS=y but you didn't set CONFIG_LEDS_CLASS.
We need to set CONFIG_NEW_LEDS and CONFIG_LEDS_CLASS both to compile it.
To fix it, I added two reverse dependencies "select NEW_LEDS" and "select CONFIG_LEDS_CLASS".

2012ë 09ì 10ì 14:28, Randy Dunlap ì ê:
On 09/09/2012 08:16 PM, G.Shark Jeong wrote:

From: "G.Shark Jeong" <gshark.jeong@xxxxxxxxx>

This driver is a general version for LM3639 backlgiht driver chip of TI.

Put NEW_LEDS and LEDS_CLASS into Kconfig file to reduce additional configuration works in LEDs.


Signed-off-by: G.Shark Jeong <gshark.jeong@xxxxxxxxx>

Linus has asked patch committers to use Reported-by when appropriate.

Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

drivers/video/backlight/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 2ed68bd..e6c78cd 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -356,6 +356,8 @@ config BACKLIGHT_LM3639
tristate "Backlight Driver for LM3639"
select REGMAP_I2C
+ select NEW_LEDS
+ select LEDS_CLASS
This supports TI LM3639 Backlight + 1.5A Flash LED Driver

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at