Re: [PATCH v6 11/12] KVM: introduce readonly memslot

From: Avi Kivity
Date: Sun Sep 09 2012 - 09:42:15 EST

On 09/07/2012 02:14 PM, Jan Kiszka wrote:
>> $ grep __KVM_HAVE include/linux/kvm.h | wc -l
>> 20
> Yes, mistakes of the past.
>> As your suggestion, userspace will always use the CAP even if the CAP
>> is not really supported. We do not need care the overload on other arches?
> Generally, userspace can only find out if a CAP is supported by testing
> during runtime. Sometimes, the CAP may also be used to switch features
> that are only available on certain archs. But this particular feature
> should surely become a generic one soon, and the code you could skip in
> userspace is truly minimal.

You also need them for build time, to see if the ioctl names and
structures are defined. qemu chose not to do this ifdeffery but we must
not make that choice for other userspace.

In this case the feature is indeed generic and the names introduced are
globally available, so the conditional is unneeded. But for other cases
it may be needed.

error compiling committee.c: too many arguments to function
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at