Re: [PATCH 4/7 V6] workqueue: fix idle worker depletion

From: Tejun Heo
Date: Sat Sep 08 2012 - 13:53:52 EST


Hello,

On Sun, Sep 09, 2012 at 01:50:41AM +0800, Lai Jiangshan wrote:
> >> + if (worker_maybe_bind_and_lock(manager))
> >> + worker_clr_flags(manager, WORKER_UNBOUND);
> >> + }
> >> +}
> >
> > We can reuse busy_worker_rebind_fn(), right?
>
> busy_worker_rebind_fn() releases the gcwq->lock. we can't release
> the lock here.

Why so? Can you please elaborate?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/