Re: [PATCH 0/7 V6] workqueue: fix hoplug things

From: Tejun Heo
Date: Sat Sep 08 2012 - 13:50:10 EST

Hello, Lai.

On Sun, Sep 09, 2012 at 01:46:59AM +0800, Lai Jiangshan wrote:
> > * Instead of MANAGING, add pool->manager.
> >
> > * Fix the idle depletion bug by using pool->manager for exclusion and
> > always grabbing pool->manager_mutex. Hotplug can use pool->manager
> > to schedule rebind work (or UNBIND) to the manager.
> >
> > Thoughts?
> Don't need. my worry is wrong.

So, your worry was incorrect and the above is what we're gonna do, no?

> > Also, can you please base the fix patches on top of wq/for-3.6-fixes?
> > It's getting quite confusing.
> >
> > git:// for-3.6-fixes
> I base on wq/for-3.7 of several days ago.
> I can change the base, but which blanch should patch5,6,7 base on?

Please create two patches, first introducing pool->manager_mutex and
second fixing the depletion bug by making manager always grab
manager_mutex on top of wq/for-3.6-fixes. For the rest of the series,
please wait for me to merge the for-3.6-fixes into for-3.7 and base on
top of them and *please* stop sending restructuring patches before the
fixes are settled. It's wasting time for both of us.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at