Re: [PATCH v2 05/12] perf tools: include basename for non-glibc systems

From: David Ahern
Date: Sat Sep 08 2012 - 10:34:05 EST

On 9/8/12 3:09 AM, Pekka Enberg wrote:
It's safe to include <libgen.h> on glibc Linux systems as well, no? So
there's no need to check for __BIONIC__.

Theoretically, yes. In reality compile fails in multiple places. basename can modify the string passed to it and several places in perf are passing a string marked const. Oops. I'll fix those places and remove the BIONIC conditional for libgen.h

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at