Re: [PATCH] UV: fix incorrect tlb flush all issue

From: Andrew Morton
Date: Thu Sep 06 2012 - 19:11:29 EST


On Fri, 24 Aug 2012 16:57:35 +0800
Alex Shi <alex.shi@xxxxxxxxx> wrote:

> The flush tlb optimization code has logical issue on UV platform.
> It doesn't flush the full range at all, since it simply
> ignores its 'end' parameter (and hence also the "all" indicator)
> in uv_flush_tlb_others() function.
>
> This patch fixed this issue, but untested due to hardware leaking.

Well, it doesn't really come very close to being compilable:

arch/x86/platform/uv/tlb_uv.c: In function 'bau_process_message':
arch/x86/platform/uv/tlb_uv.c:283: error: 'struct bau_pq_entry' has no member named 'end'
arch/x86/platform/uv/tlb_uv.c:284: error: 'struct bau_pq_entry' has no member named 'start'

Cliff, could you please help out here?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/