Re: [PATCH 1/2] module: allow loading module from fd

From: Rusty Russell
Date: Wed Sep 05 2012 - 23:03:12 EST


Kees Cook <keescook@xxxxxxxxxxxx> writes:
> This changes the init_module syscall so that when the first argument
> (blob address) is NULL, the second argument is used as a file descriptor
> to the module (instead of length). The third argument (module arguments)
> remains unchanged.

Do you know why Linus hates ioctls? It's because they encourage
casual introduction of new ABIs.

I see you managed the same feat with a different system call. It avoids
the agony of debate a new system call would entail. Very clever.

Now do it properly.
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/