RE: [PATCH 4/4] tools: hv: Parse /etc/os-release

[KY Srinivasan]

> -----Original Message-----
> From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, September 05, 2012 12:58 PM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> ben@xxxxxxxxxxxxxxx; thozza@xxxxxxxxxx; dcbw@xxxxxxxxxx
> Subject: Re: [PATCH 4/4] tools: hv: Parse /etc/os-release
> 
> > +			if (!strcmp(buf, "NAME"))
> > +				os_name = strdup(value);
> > +			else if (!strcmp(buf, "VERSION_ID"))
> > +				os_major = strdup(value);
> 
> strdup can fail. The case where it leaks because NAME= occurs twice is
> harmless enough but the strdup ought to be checked or add an x_strdup()
> helper.

I will fix this and resend this patch.

Thank you,

K. Y



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/