Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

From: Matthew Garrett
Date: Wed Sep 05 2012 - 09:44:57 EST


On Wed, Sep 05, 2012 at 02:30:10PM +0100, Alan Cox wrote:
> On Wed, 5 Sep 2012 14:20:07 +0100
> Matthew Garrett <mjg@xxxxxxxxxx> wrote:
> > We've no good way of knowing what the firmware's giving us - we copy it
> > to RAM in the EFI init process, so by the time we're here it certainly
> > shouldn't be on the PCI bus.
>
> In which case how do you know that physical address you have been given
> actually has a mapping in kernel virtual space. It seems like it ought to
> be getting an ioremap in that case ?
>
> phys_to_virt is not valid for arbitary addresses.

The pages are allocated as EFI_LOADER_DATA, and that gets mapped as
E820_RAM.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/