Re: [PATCH v5 3/4] regulator: anatop-regulator: convert to usesyscon to access anatop register

From: Shawn Guo
Date: Tue Sep 04 2012 - 07:34:25 EST


On Tue, Sep 04, 2012 at 11:20:10AM +0800, Dong Aisheng wrote:
> +
> + anatop_np = of_get_parent(np);
> + if (!anatop_np)
> + return -ENODEV;
> + sreg->anatop = syscon_node_to_regmap(anatop_np);
> + if (IS_ERR(sreg->anatop))
> + return PTR_ERR(sreg->anatop);
> +
With of_node_put moved out from syscon_node_to_regmap, shouldn't
we put anatop_np here then?

--
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/