Re: [PATCH v2] udf: extent cache implementation for manipulatingblock map

From: Jan Kara
Date: Tue Sep 04 2012 - 05:55:53 EST


On Tue 04-09-12 16:45:42, Namjae Jeon wrote:
> 2012/9/3, Jan Kara <jack@xxxxxxx>:
> >> +void udf_clear_extent_cache(struct udf_inode_info *iinfo)
> >> +{
> >> + if (iinfo->cached_extent.sanity) {
> >> + brelse(iinfo->cached_extent.epos.bh);
> >> + memset(&iinfo->cached_extent, 0, sizeof(struct udf_ext_cache));
> >> + }
> >> +}
> >> +
> > I think udf_clear_entent_cache() should take i_extent_cache_lock. Or if
> > you are sure it's not needed, you need a good documentation why.
> Documentation ? I am a little confusing.. It means udf.txt is in
> Documentation/filesystem/ ?
> or comment about clear extent function ?
I meant in a comment before udf_clear_extent_cache() function...

Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/