Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework

From: Linus Walleij
Date: Mon Sep 03 2012 - 07:51:53 EST


On Mon, Sep 3, 2012 at 1:28 PM, Arun MURTHY <arun.murthy@xxxxxxxxxxxxxx> wrote:
>> On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding <thierry.reding@avionic-
>> design.de> wrote:
>>
>> > This commit moves the driver to drivers/pwm and converts it to the new
>> > PWM framework.
>> >
>> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
>> > ---
>> > Note: I'll take this through the PWM tree, but I'd like to have it
>> > acknowledged by a few people who know the hardware and can actually
>> > test whether this still works.
>>
>> Pls include Arun on these patches, he'll know best if it'll work or not.
>>
>> I have one generic question: will this alter the layout of sysfs so we need to
>> change userspace? I had such issues before when moving drivers to new
>> busses...
>>
>
> Since this pwm framework is still a set of exported functions in a header file,
> the file architecture doesn't really matter.
> Using this driver, either leds-pwm and backlight-pwm is used to register and
> this is where actual registration happens(sysfs entry is created).

OK sounds good to me,
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/