Re: [PATCH 08/13] perf tools: Use __maybe_used for unused variables

From: Namhyung Kim
Date: Sun Sep 02 2012 - 21:15:15 EST


Hi,

On Wed, 29 Aug 2012 01:04:25 +0300, Irina Tirdea wrote:
> perf defines __used to for marking unused variables.
> The variable __used is defined to __attribute__((__unused__)), which
> contradicts the kernel definition to __attribute__((__used__))
> for new gcc versions. On Android), __used is also defined in
> system headers and this leads to warnings like:
> warning: '__used__' attribute ignored
>
> This patch simply replaces all instances of __used with __maybe_unused
> so there will be no such warnings.

How about just using '__unused' for less typing?

Btw, the patch looks whitespace-damaged.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/