Re: [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt

From: Tejun Heo
Date: Tue Aug 28 2012 - 03:04:03 EST


Hello,

On Mon, Aug 27, 2012 at 9:36 PM, Lai Jiangshan <eag0628@xxxxxxxxx> wrote:
>> But then the completion could be triggered prematurely, no?
>
> No, the idle_worker_rebind() can't be called until rebind_workers()
> finish counting and release the gcwq->lock.

I see but I still wanna keep it counting from 1. That's an
established pattern and is more robust. I really don't see what we're
gaining by doing it differently.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/