Re: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', whatit really does

[Adam Lee]

On Thu, Aug 23, 2012 at 04:10:01PM -0400, Steven Rostedt wrote:
> Sorry for the late reply.
> 
> On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote:
> > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
> > set new symbols to 'n', but instead sets it to their default values.
> > 
> > So, this patch replace 'oldnoconfig' with 'olddefconfig', stop making
> > people confused.
> > 
> > PS: the document in conf.c fixed in another mail, "[PATCH] [Signed-off]
> > kconfig: document oldnoconfig to what it really does in conf.c"
> 
> The reason that I didn't make this change myself is that I'm afraid that
> things depend on 'oldnoconfig' existing. For example, ktest.pl has it
> hardcoded. That may not be the only script that uses it.

Yes, but I think very few scripts use it up to now, because it's
"fresh".

> I think a better solution would be to make oldnoconfig do just that, set
> everything to 'n' as the name implies, and we can create a olddefconfig
> to do what it does now.

Lots of configs can't be set to 'n', they expect digit or other string.

Later we fix it, bigger the problem becomes.

-- 
Regards,
Adam Lee
http://adam8157.info
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/