Re: [patch 0/9] extended fdinfo via procfs series, v7

[J. Bruce Fields]

On Thu, Aug 23, 2012 at 09:02:39PM +0400, Cyrill Gorcunov wrote:
> On Thu, Aug 23, 2012 at 11:25:45AM -0400, J. Bruce Fields wrote:
> > On Thu, Aug 23, 2012 at 05:56:06PM +0400, Cyrill Gorcunov wrote:
> > > On Thu, Aug 23, 2012 at 09:52:34AM -0400, J. Bruce Fields wrote:
> > > > 
> > > > I don't have any opinion on whether there should be a configuration
> > > > option.  Just want to make sure the cost when it's turned on is still
> > > > taken seriously.
> > > 
> > > I see. So, does the rest of series looks fine for you (except this config
> > > moment)?
> > 
> > You're using the common filehandle code instead of encoding your own
> > from scratch, which was my only serious objection.
> > 
> 
> Wait, Bruce, now I'm confused, if I understand all correctly
> using common filehandle code from exportfs is preferred,

Right, that's what I meant, sorry if I was unclear.

--b.

> or
> not? What you mean by "encoding your own from scratch"? Could
> you please clarify?
> 
> > I haven't reviewed the rest of it carefully.
> 
> ok
> 
> 	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/