Re: Unable to mount NFSROOT: pcie change breaks e1000?

[Bjorn Helgaas]

On Thu, Aug 23, 2012 at 9:03 AM, Jiang Liu <liuj97@xxxxxxxxx> wrote:
> Hi Bjorn,
>         Could you please help to fold this small patch into
> "[5/40] PCI/core: Use PCI Express Capability accessors"?
> It fixes a bug reported by Fengguang.

Thanks, I folded it in.  I looked briefly at whether a similar fix is
needed in pci_restore_pcie_state().  I don't *think* so, but it
wouldn't hurt for you to also double-check and let me know if it does.

Bjorn

> On 08/23/2012 09:31 AM, Jiang Liu wrote:
>> Hi Fengguang,
>>       Could you please help to verify whether following patch
>> fixes the issue?
>>       Thanks!
>>
>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
>> index f6b491b..fac08f5 100644
>> --- a/drivers/pci/pci.c
>> +++ b/drivers/pci/pci.c
>> @@ -842,6 +842,9 @@ static int pci_save_pcie_state(struct pci_dev *dev)
>>         struct pci_cap_saved_state *save_state;
>>         u16 *cap;
>>
>> +       if (!pci_is_pcie(dev))
>> +               return 0;
>> +
>>         save_state = pci_find_saved_cap(dev, PCI_CAP_ID_EXP);
>>         if (!save_state) {
>>                 dev_err(&dev->dev, "buffer not found in %s\n", __func__);
>>
>> On 2012-8-23 8:46, Fengguang Wu wrote:
>>> buffer not found
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/