Re: [PATCH 19/36] autonuma: memory follows CPU algorithm andtask/mm_autonuma stats collection

From: Andrea Arcangeli
Date: Wed Aug 22 2012 - 18:46:07 EST


Hi Andi,

On Thu, Aug 23, 2012 at 12:37:33AM +0200, Andi Kleen wrote:
> >
> > This comment seems quite accurate to me (btw I taken it from
> > sched-numa rewrite with minor changes).
>
> I had expected it to describe the next function. If it's a strategic
> overview maybe it should be somewhere else.

Well the next function is last_nid_set, and that's where the last_nid
logic is implemented. The comment explains why last_nid statistically
provides a benefit so I thought it was an ok location, but I welcome
suggestions to move it somewhere else.

Thanks,
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/